Fix call on non-object in ping() with PDO wrapper #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue when calling `ping()` where `$this->platform` is null. Happened to me because using the `'pdo'` param bypasses the `connect()` method and the platform is never set without explicitly calling the method. Not sure if this is the most elegant way to deal with this but it worked enough for my purposes so I figured I should submit a PR.
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1260 We use Jira to track the state of pull requests and the versions they got |
|
There are a few other spots that should probably be calling getDatabasePlatform as well. This is a simple and straightforward fix, so I'll merge. |
billschaller
pushed a commit
that referenced
this pull request
Jul 15, 2015
Fix call on non-object in ping() with PDO wrapper
billschaller
pushed a commit
that referenced
this pull request
Jul 15, 2015
Fix call on non-object in ping() with PDO wrapper
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when calling
ping()where$this->platformis null. Happened to me because using the'pdo'param bypasses theconnect()method and the platform is never set without explicitly calling the method.Not sure if this is the most elegant way to deal with this but it worked enough for my purposes so I figured I should submit a PR.